chore(docs): rewording pending tests #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
boneskull
suggested changes
Mar 18, 2018
docs/index.md
Outdated
| @@ -419,7 +419,7 @@ describe('Array', function() { | |||
| }); | |||
| ``` | |||
|
|
|||
| Pending tests will be reported as such. | |||
| Such incomplete tests will still be included in the test results but as a pending test and not as a failure. | |||
There was a problem hiding this comment.
Hmm, this is a bit of a run-on sentence. Maybe:
"Pending tests will be included in the test results, and marked as pending. A pending test is not considered a failed test."
boneskull
added
the
semver-patch
|
@boneskull I updated the text based on your suggestion |
boneskull
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes #3133
Rewording of part of the documentation
Alternate Designs
Based on the proposed rewording, I proposed the one that makes more sense
Why should this be in core?
N/A
Benefits
Better understanding for users
Possible Drawbacks
None
Applicable issues
Bugfix