Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(changelog): fix links to some PRs #3276

Merged
merged 1 commit into from
Mar 18, 2018
Merged

fix(changelog): fix links to some PRs #3276

merged 1 commit into from
Mar 18, 2018

Conversation

tagoro9
Copy link
Contributor

@tagoro9 tagoro9 commented Mar 9, 2018

Description of the Change

I was checking the changelog of the latest versions and realized that some PR links had the wrong URL. They were https://github.com/mochajs/mocha/pulls/:id and they should be .../pull/:id.

This PR fixes those broken links.

@tagoro9
fix(changelog): update links to some PRs
5b6a401 
Replace /pulls/:id wtih /pull/:id
@jsf-clabot
Copy link

jsf-clabot commented Mar 9, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 90.077% when pulling 5b6a401 on relayrides:fix_changelog_urls into d76f490 on mochajs:master.

@outsideris
Copy link
Contributor

Good catch.

@outsideris outsideris added the area: documentation anything involving docs or mochajs.org label Mar 12, 2018
@boneskull boneskull added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Mar 18, 2018
@boneskull boneskull added this to the next milestone Mar 18, 2018
@boneskull boneskull merged commit 27af2cf into mochajs:master Mar 18, 2018
@boneskull
Copy link
Contributor

Thanks!

@tagoro9 tagoro9 deleted the fix_changelog_urls branch March 19, 2018 15:22
This was referenced Mar 24, 2018
Merged
Merged
@renovate renovate bot mentioned this pull request Apr 17, 2018
Merged
This was referenced Sep 22, 2018
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
This was referenced Sep 29, 2018
Closed
Closed
Closed
Closed
Open
This was referenced Oct 25, 2018
Merged
Merged
Closed
Closed
This was referenced Nov 1, 2018
Merged
Merged
Merged
This was referenced Nov 9, 2018
Merged
Closed
Merged
This was referenced Nov 19, 2018
Closed
Merged
This was referenced Dec 1, 2018
Closed
Merged
Merged
This was referenced Dec 8, 2018
Merged
Closed
Merged
Closed
This was referenced Dec 23, 2018
Closed
Closed
This was referenced Mar 14, 2020
Closed
Closed
Closed
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

@outsideris outsideris outsideris approved these changes

Assignees
No one assigned
Labels
area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
v5.0.5
Development

Successfully merging this pull request may close these issues.
6 participants
@tagoro9 @jsf-clabot @coveralls @outsideris @boneskull @ematipico