Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate API documentation #3239

Closed
wants to merge 14 commits into from
Closed

generate API documentation #3239

wants to merge 14 commits into from

Conversation

dfberry
Copy link
Contributor

@dfberry dfberry commented Feb 11, 2018

Changes in jsdocs comments only in order to product api docs.

Description of the Change

changes to get markdown for api docs using documentation.js

Alternate Designs

The current code exports, inherits, and layers make jsdocs a bit of a mash up. There are some errors here but I'm not sure if the easier fix is jsdocs annotations or code changes.

Why should this be in core?

Shows APIs

Benefits

Better communication for API usage.

Possible Drawbacks

Some assumptions are made about inheritance and relationships. I may have left things off or added things that should be there.

Applicable issues

I need to understand how jsdocs is built by documentationjs to resolve some of the existing issues.

@boneskull
Copy link
Contributor

Thanks. @dfberry package-scripts.js needs to be linted

@boneskull boneskull added the area: documentation anything involving docs or mochajs.org label Feb 28, 2018
@boneskull boneskull changed the title Issue/3138 generate API documentation Feb 28, 2018
Copy link
Contributor

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, thanks.

  • Can we generate HTML docs instead?
  • lint package-scripts.js

I'm not really happy with how everything hangs off of the base Mocha namespace, but I'd have to play with documentation a bit more to understand the best way to use docstrings to get it looking like how I envisioned. Regardless, that shouldn't hold up merging this.

@boneskull boneskull added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Feb 28, 2018
Munter added 7 commits April 12, 2018 21:17
* origin/master: (58 commits)
  Tap reporter: report thrown error messages (#3317)
  fix circular objects in json reporter; closes #2433 (#3318)
  fix wrong version in package.json! [ci skip]
  doc precision for exclusive tests
  optimize package-scripts.js
  PATH workaround for Travis CI bug
  further build improvements (#3315)
  update package-lock.json for v5.0.5 [ci skip]
  improve caching performance in CI (#3310)
  update stages and build matrices (#3308)
  add update-contributors script; closes #3289 (#3290)
  upgrade eslint; lint
  use build stages for Travis CI (#3302)
  use exact version of minimatch [ci skip]
  remove 0-byte file [ci skip]
  Refactor Reporter tests (#3272)
  #1577 Add "--exclude" Option (#3210)
  Release v5.0.5
  add changes for v5.0.5 [ci skip]
  remove default js in "--watch-extensions" option; closes #3275
  ...
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 90.054% when pulling e1080a5 on dfberry:issue/3138 into 1acea30 on mochajs:master.

Munter pushed a commit that referenced this pull request Apr 12, 2018
Fixes #3138
Replaces and closes #3239

basically working

Suite and utils work

Runner and Suite datatypes work

Hook extends Runnable - at least link in description

hook is child of mocha and has error

first solid pass

Remove attempted module link from Hook to Runnable because of documentationjs/documentation#820

Switch API documenation to html output, link to them, include in site build

Update TOC

Bring lock file in sync with package.json

Linting

Update package-lock.json
@Munter Munter closed this in #3323 Apr 12, 2018
Munter pushed a commit that referenced this pull request Apr 12, 2018
Fixes #3138
Replaces and closes #3239

basically working

Suite and utils work

Runner and Suite datatypes work

Hook extends Runnable - at least link in description

hook is child of mocha and has error

first solid pass

Remove attempted module link from Hook to Runnable because of documentationjs/documentation#820

Switch API documenation to html output, link to them, include in site build

Update TOC

Bring lock file in sync with package.json

Linting

Update package-lock.json
boneskull pushed a commit that referenced this pull request Apr 12, 2018
Fixes #3138
Replaces and closes #3239

basically working

Suite and utils work

Runner and Suite datatypes work

Hook extends Runnable - at least link in description

hook is child of mocha and has error

first solid pass

Remove attempted module link from Hook to Runnable because of documentationjs/documentation#820

Switch API documenation to html output, link to them, include in site build

Update TOC

Bring lock file in sync with package.json

Linting

Update package-lock.json
sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
Fixes mochajs#3138
Replaces and closes mochajs#3239

basically working

Suite and utils work

Runner and Suite datatypes work

Hook extends Runnable - at least link in description

hook is child of mocha and has error

first solid pass

Remove attempted module link from Hook to Runnable because of documentationjs/documentation#820

Switch API documenation to html output, link to them, include in site build

Update TOC

Bring lock file in sync with package.json

Linting

Update package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants