Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bundling; closes #3091 #3145

Closed
wants to merge 2 commits into from
Closed

fix bundling; closes #3091 #3145

wants to merge 2 commits into from

Commits on Dec 12, 2017

  1. fix bundling; closes #3091

    This became too difficult to manage on the command-line.
    
    What we're trying to do here is ship a version of the `Buffer` shim
    which plays well with IE9/IE10.  Browserify ships with a version which
    does NOT play well, meaning we have to force it to use the version
    we choose (`[email protected]`).
    
    The fix is in two parts:
    
    1.  `insertGlobalVars` option replaces usages of global `Buffer` with
    `require('/path/to/mocha/node_modules/buffer').Buffer`
    2.  Any *other* module which explicitly requires `buffer` or, yes,
    `buffer/`, must *also* use `/path/to/mocha/node_modules/buffer`
    
    If *both* of these are not in place, Browserify will use its *own*
    version of the `buffer` shim.
    boneskull committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    03c866c View commit details
    Browse the repository at this point in the history
  2. test support for #3091

    - this will assert that using `import` with `mocha.js` does not break
    - fix: remove missing `Makefile` target; add `test-browser-esm` target
    - fix: update invalid comments regarding running SauceLabs locally in
      `karma.conf`
    - fix: break if attempting to run Karma on AppVeyor
    - refactor Karma test flags to all use `MOCHA_TEST` env var
    - a few reformats
    
    Signed-off-by: Christopher Hiller <[email protected]>
    boneskull committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    add3281 View commit details
    Browse the repository at this point in the history