options.reporterOptions are used for progress reporter

[canoztokmak]

Progress reporter had multiple options for configuring the reporter,
but it needed the optional fields under options object, while
those fields are provided under options.reporterOptions.
This commit enables usage of optional fields from reporterOptions.

[jsf-clabot]

All committers have signed the CLA.

[canoztokmak]

solution for issue #2661

[canoztokmak]

ping

[xxczaki]

@boneskull i think this should be merged & the issue #2661 closed + this is a pretty old pr :/

[boneskull]

old PR's happen

[boneskull]

LGTM, thanks

[boneskull]

@canoztokmak Can you please try this again? It seems this introduced breaking changes

[canoztokmak]

Hey @boneskull,

The reporter options are passed as a field inside options. See example below:
https://github.com/mochajs/mocha/blob/master/lib/reporters/xunit.js#L52

But in test, the options are passed directly. So the tests are validating the current behaviour, which is wrong. See below:
https://github.com/mochajs/mocha/blob/master/test/reporters/progress.spec.js#L99

There was no tests when I introduced the fix, that's why build did not failed back then. I think I can fix the tests and send another PR including with this change in a few days.

[canoztokmak]

@boneskull I've just sent another PR to solve the issue.
#3182