Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix diff output for String objects; closes #2496 #2499

Merged
merged 1 commit into from
Sep 27, 2016
Merged

fix diff output for String objects; closes #2496 #2499

merged 1 commit into from
Sep 27, 2016

Conversation

boneskull
Copy link
Contributor

  • rename some exported functions/vars as to use locally
  • update JSDoc comments

@boneskull
Copy link
Contributor Author

Failing in IE7/IE8; needs more investigation. We're using json3 to avoid the broken JSON implementations, so it shouldn't be that...

@boneskull
Copy link
Contributor Author

String seems broken in IE7/IE8 as verified through a SauceLabs session. The return value of new String('foo') is [undefined, undefined, undefined].

@boneskull
fix diff output for String objects; closes #2496
8fd7ba1 
- rename some exported functions/vars as to use locally
- update JSDoc comments
- includes IE7/8 support
@boneskull boneskull merged commit 8431cb3 into master Sep 27, 2016
@boneskull boneskull deleted the issue/2496 branch September 27, 2016 07:29
sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
@boneskull
fix diff output for String objects; closes mochajs#2496 (mochajs#2499)
8dfdf4f 
- rename some exported functions/vars as to use locally
- update JSDoc comments
- includes IE7/8 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@boneskull