Use original Error object for uncaught errors when provided #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@freshp86 this helps with stack traces in Chrome's WebUI tests |
Closed
|
@mgiuffrida going to try to release v3.0.0 tonight, so you might want to wait until that happens before retrying. |
boneskull
added
type: feature
Uses the existing error instead of creating a new stack trace from the current context.
|
@boneskull thanks, that was silly of me. From the actual |
| @@ -51,8 +51,11 @@ process.removeListener = function(e, fn){ | |||
|
|
|||
| process.on = function(e, fn){ | |||
| if ('uncaughtException' == e) { | |||
| global.onerror = function(err, url, line){ | |||
| fn(new Error(err + ' (' + url + ':' + line + ')')); | |||
| global.onerror = function(err, url, line, col, errObj){ | |||
There was a problem hiding this comment.
should col be leveraged?
There was a problem hiding this comment.
It isn't currently, and it normally isn't in JS, right?
|
Closing for inactivity; please reopen if continuing. Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include stack trace of async errors by not throwing away the Error passed by global.onerror.
Fixes #958, the same issue referenced at #815 (comment).