Move to-iso-string from dev dependency to dependency #2274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to-iso-string is used in lib/utils.js since mochajs#2231 Fixes mochajs#2272
|
I can confirm this fixes the errors I'm seeing when trying to run mocha on my project. |
|
thanks, just running tests atm. I committed bd9450b before I saw the PRs... |
|
No problem, @boneskull , when will new release make? |
|
I'll release 2.5.1 as soon as travis gives the green light |
|
released |
|
Yay! Incidentally, I've made the exact same mistake. My tests can't test if my app works without the tests installed. :-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to-iso-string is used in lib/utils.js since #2231
Fixes #2272