-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for multiple reporters #1772
Conversation
function done(failures) { | ||
function runnerDone(failures) { | ||
var remain = reporters.length | ||
, reporterDone = function(failures) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi: with the linting work that's being done, we're not going to be using leading commas. also, the below conditional will need curlies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roger.
Is this in-progress or...? |
2f458ab
to
2952eca
Compare
@benvinegar Awesome work on this btw :)
@boneskull It might be difficult without a writeable stream being passed to each reporter, since they all invoke either process.stdout.write or console.log directly. Ideally, mocha would pass process.stdout to any reporter writing to stdout, and an fs.WriteStream when writing to a file (or just some buffer that gets written at the end of exec). At that point you'd probably end up with something similar to what you mentioned in #1772 (comment) @benvinegar Did you have an easier solution in mind for getting the distinct output streams working? I've got some cycles this week too if you wanna collaborate. |
This would be great to have :) |
This is a super useful feature. It appears the development has stalled on it? |
This is stalled. Sorry everyone. Ultimately I was driven on this project because it was important for a project I was working on, but I've since moved on and it's no longer in my sights. The small handful of comments over the past 6 months hasn't really motivated me sufficiently to continue. @danielstjules – This is a super late reply, but if we could get together to push through on this, I'm game. Otherwise I can help someone else take over. |
+1 really need this for CI. |
I would also love to have this for the same reason mentioned by @antoinebrault. |
Anyway, a prototype of #1969 will have this built in |
Please, someone finish merging this; having to run your entire suite multiple times just to get xunit and coverage reports is lame. |
@antoinebrault @machineghost @lpinca you may want to take this PR over and see if you can get it finished. my focus is elsewhere atm |
@boneskull @benvinegar I'll be integrating the current work on latest and add the missing pieces, any things to keep in mind? I'm working over master, should I do it on 3.0 instead? |
First question: most of the reporters in mocha do a direct Any reason not to do such change?. Since this requires updating every reporter, I'm guessing we should do that on an independent PR?. |
See #2184 |
Continuation of #1681, targeted against 2.x (master) instead of 3.x.
Necessary for completion:
--reporter-options
needs to be capable of configuring each reporter