reporter-specific options and support for the xunit reporter to output to a file (#2)

[demmer]

(Rework of #1106 to merge cleanly onto master and to address PR comments.)

Support for generic reporter options and an optional .done() hook for reporters
to clean up before exiting.

The xunit reporter uses these hooks to optionally write output to a file when run
in node. By default it still uses console.log to keep support for running in browser.

[demmer]

@travisjeffery I believe I've addressed all your comments from the other PR. Are there any other concerns?

If not can you please merge this, and I'd also appreciate if you could push a new release that contains the change.

[rmg]

Code looks straight forward to me, FWIW.

I also happen to be using it on my CI setup, so I'm somewhat biased in wanting to see it upstream so I don't have to maintain a fork.

[crocket]

I've waited for this. Please merge it.

[demmer]

@travisjeffery, @visionmedia If for some reason you don't want to take this whole change, how about just taking commit 6acbc7f which adds the .done support for the reporter? With that at least I could use my own xunit reporter to get the file output support, and others could do similarly.

[tunnckoCore]

This with reporter-specific options would be great - it is must. I also plan to develop benchmark reporter and this will help me.

[demmer]

Rebased on top of the latest master to fix merge conflicts.

Any updates from the maintainers as to what if anything is holding up merge? @travisjeffery I thought I addressed all of your concerns back in May.

[jbnicolai]

@demmer the new maintainers are just cautiously working their way through the issues and pull requests. Thanks for the rebase and the bump - I'll look at this shortly 😄

[travisjeffery]

ya i have a branch where i made some changes, lemme see if i can dig that up and merge it

[demmer]

Thanks!

On Sat, Jul 12, 2014 at 1:51 PM, Travis Jeffery [email protected]
wrote:

ya i have a branch where i made some changes, lemme see if i can dig that
up and merge it

—
Reply to this email directly or view it on GitHub
#1218 (comment).

Michael Demmer
Jut - VP Engineering
[email protected]

[crocket]

It's been months since this pull request was submitted.
How to control reporter options programmatically should be documented.
Other than lack of documentation, it seems good to go.
Can anyone just merge it?

[kri5]

👍

[tunnckoCore]

👍

[elkwood]

👍

[demmer]

@travisjeffery Another couple of months have gone by so I'd like to bump this once again. Again is there anything that is holding up this merge? You mentioned that you had "made some changes".

[abstratt]

Looking forward to seeing this integrated. Had to remove all logging in my code so I could generate valid XUnit output with mocha.

[kri5]

👍

[ngerakines]

Any update on this? Would love to see this merged in and made available.

[bleadof]

👍

[barneycarroll]

👍

This is a basic necessity for our CI. Without this, I can run my tests on my own and tell the rest of the world I'm happy with my code but I can't convince our pipeline this is the case. @demmer 's put the work in of plugging this in a couple of times and has rebased to deal with the wait. Travis CI passes! Can't somebody just click 'accept'?

[tunnckoCore]

Mm yep.. Months waiting..

[bleadof]

Seriously, I'm at this point 😢

[boneskull]

@travisjeffery if you have a branch w your changes somewhere I can take care of this.

[elkwood]

You should be able to merge this pull request if I'm not mistaken. https://help.github.com/articles/merging-a-pull-request/