Hostile Custom Runner API - Silent crash

[fgarcia]

I've just noticed that my custom runner started crashing silently. The problem is that Runner errors cause Mocha to crash with an OK exit status and no error notice.

For example:

var mocha = require('mocha');

function FooReporter(runner) {
  mocha.reporters.Base.call(this, runner);
  
  //return visual(runner)

  let count = 0
  runner.on('suite', function(test){
  })

  runner.on('pass', function(test){
    count++
    if(count > 3) throw Error('An error!')
    process.stdout.write('.')
  });

  runner.on('fail', function(test, err){
    process.stdout.write('x')
  });

  runner.on('end', function(){
    console.log()
    console.log('end!')
  });
}

module.exports = FooReporter;

Using the above runner will silently crash Mocha after 3 test passes. The thrown Error will not be shown and shell exit status of mocha will be 0

[ScottFreeCode]

This could be related to #2890 (comment)

[ORESoftware]

You mean custom reporter, not custom runner right?

[fgarcia]

My mistake. Yes I meant custom reporter. Any error inside the reporter will cause the runner to fail silently

…

On Jul 9, 2017 04:30, "Operations Research Engineering Software+" < ***@***.***> wrote: You mean custom reporter, not custom runner right? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2777 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPc5T6l6Dbpv6MmOT7GSY8oDibhOtEZks5sMDstgaJpZM4NFXb5> .

[fgarcia]

Closing this issue because it seems that since my report, now Mocha reporters crash with "reporter blew up with error" message and there is even a stacktrace