-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this.slow()
doesn't work in describe callbacks like this.timeout
#2311
Comments
|
I'm confused because in test 2, calling
|
OK, thanks. that's a bug. this is mostly for my benefit, but the explanation: Runnable.prototype.slow = function(ms) {
if (!arguments.length) {
return this._slow;
}
if (typeof ms === 'string') {
ms = milliseconds(ms);
}
debug('timeout %d', ms);
this._slow = ms;
return this;
}; When you call Context.prototype.slow = function(ms) {
this.runnable().slow(ms);
return this;
} If the latter function is called without a parameter, |
ensures slow() called w/o args does not blast value; closes #2311
If I understand the docs correctly, I expect neither of the tests to timeout or have slow warnings because they're both covered by
this.timeout
andthis.slow
calls in the describe section. Neither of the tests timeout, but the first test (not covered by its own redundantthis.slow
) has a slow warning still:mocha version 2.5.3
The text was updated successfully, but these errors were encountered: