Skip to content

ci: fix not honoring PACKAGES setting in gha Windows runners #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 2 commits into from
Sep 23, 2024
Merged

ci: fix not honoring PACKAGES setting in gha Windows runners #157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ef9b40
ci: fix not passing PACKAGES on windows runners
kolyshkin Sep 21, 2024
eaecf09
ci: give a name to a step
kolyshkin Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,22 @@ jobs:
go-version: [1.18.x, 1.22.x, 1.23.x]
platform: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04, windows-latest, macos-12, macos-14]
runs-on: ${{ matrix.platform }}
defaults:
run:
shell: bash
steps:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
- name: Checkout code
uses: actions/checkout@v4
- if: ${{ matrix.go-version == '1.18.x' }}
- name: Set PACKAGES env
if: ${{ matrix.go-version == '1.18.x' }}
run: |
# This corresponds with the list in Makefile:1, but omits the "userns"
# and "capability" modules, which require go1.21 as minimum.
echo 'PACKAGES="mountinfo mount sequential signal symlink user"' >> $GITHUB_ENV
echo 'PACKAGES=mountinfo mount sequential signal symlink user' >> $GITHUB_ENV
- name: go mod tidy
run: |
make foreach CMD="go mod tidy"
Expand Down