Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for security opts on containers #3149

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

dperny
Copy link
Collaborator

@dperny dperny commented Aug 3, 2023

- What I did

Once, a long long time ago, we had aspirations of including a more structured way to handle security permissions in Swarmkit.

Unfortunately, this never panned out. Rather than continuing to stagnate on a might-be, this change simply add in support for the --security-opt flag and its API equivalents directly. Perfect shouldn't be the enemy of good enough.

- How I did it

Adds a security_opt field to the protobuf definition of ContainerSpec. There aren't actually any other changes needed in Swarmkit. This field will get passed into Swarmkit, then passed from Swarmkit to the executor (which lives in the engine). Swarmkit never needs to care about it.

- How to test it

Not needed.

Once, a long long time ago, we had aspirations of including a more
structured way to handle security permissions in Swarmkit.

Unfortunately, this never panned out. Rather than continuing to stagnate
on a might-be, this change simply add in support for the --security-opt
flag and its API equivalents directly. Perfect shouldn't be the enemy of
good enough.

Signed-off-by: Drew Erny <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #3149 (aa1585b) into master (b98a45d) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3149      +/-   ##
==========================================
- Coverage   61.75%   61.71%   -0.04%     
==========================================
  Files         155      155              
  Lines       31145    31145              
==========================================
- Hits        19234    19222      -12     
- Misses      10361    10384      +23     
+ Partials     1550     1539      -11     

@dperny dperny merged commit 1983e41 into moby:master Aug 8, 2023
@thaJeztah
Copy link
Member

looks related to

@dperny are there changes needed on the moby side to punch this through?

@thaJeztah
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants