Swarmkit v2 #3061
Merged
Swarmkit v2 #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like protobuf validation isn't happy (perhaps it's somewhere still referencing the old name)
Also some warning (not the cause of the failure); circleci looks to be running an ancient ubuntu version
|
Co-authored-by: Cory Snider <[email protected]> Signed-off-by: CrazyMax <[email protected]> Signed-off-by: Cory Snider <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
|
I got further, but the generated .pb.go files still have import declarations for |
|
In This makes the import path correct. |
Signed-off-by: Drew Erny <[email protected]>
Resolve package import paths to the corresponding source paths in the Makefile. Signed-off-by: Cory Snider <[email protected]>
Signed-off-by: Drew Erny <[email protected]>
I don't know how, but something about converting to a Go module and renaming it has shaken out a latent data race. The memory store implementation had made the assumption that the callback function supplied to ProposeValue() is invoked iff ProposeValue() returns err == nil. This is not strictly true: in certain rare circumstances, ProposeValue() can return a non-nil error while the callback is being executed asynchronously in another goroutine. This results in a data race, concurrently Commit()ing and Abort()ing the same memDB transaction. Fix the data race by adding a guard to prevent Abort() from being called if Commit() has been, and vice versa. Signed-off-by: Cory Snider <[email protected]>
Unit tests are failing on CircleCI but not when run locally. Crank up the verbosity to try to figure out what's happening. Signed-off-by: Cory Snider <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Swarmkit v2
- How I did it
https://github.com/icholy/gomajor
- How to test it
🤷
- Description for the changelog