agent/exec: rewrite IsTemporary() to use errors.As() #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dperny PTAL |
Codecov Report
@@ Coverage Diff @@
## master #3033 +/- ##
=======================================
Coverage 62.26% 62.27%
=======================================
Files 155 155
Lines 24531 24529 -2
=======================================
+ Hits 15275 15276 +1
Misses 7659 7659
+ Partials 1597 1594 -3 |
|
@dperny PTAL |
|
@dperny ptal |
thaJeztah
force-pushed
the
use_errors_cause
branch
from
5680177
to
d87af9f
Compare
thaJeztah
force-pushed
the
use_errors_cause
branch
from
d87af9f
to
37849a7
Compare
This makes sure we detect temporary errors both with pkg/errors.Wrap() and with native Go error wrapping. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
use_errors_cause
branch
from
37849a7
to
dace0b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #3024
Implements the suggestion I made in #3032 (comment)
This makes sure we detect temporary errors both with pkg/errors.Wrap()
and with native Go error wrapping.