-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ulimits to ContainerSpec #2967
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2967 +/- ##
==========================================
+ Coverage 61.75% 61.84% +0.08%
==========================================
Files 142 142
Lines 22999 23005 +6
==========================================
+ Hits 14204 14228 +24
+ Misses 7295 7278 -17
+ Partials 1500 1499 -1 |
api/specs.proto
Outdated
@@ -358,8 +358,18 @@ message ContainerSpec { | |||
|
|||
// CapabilityAdd sets the list of capabilities to add to the default capability list | |||
repeated string capability_add = 27; | |||
// CapabilityAdd sets the list of capabilities to drop from the default capability list | |||
// CapabilityDrop sets the list of capabilities to drop from the default capability list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! looks like we missed this in #2965)
I guess the linter did not complain about this because it skips the generated .pb.go
files 🤔
Could you perhaps create a separate PR for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the change here and created #2968 😉
Unlike Docker and docker-compose, Swarm never supported ulimits. This change introduces a new Ulimits field on the ContainerSpec type. It can be used by API clients to set desired ulimits. This is related to moby/moby#40639. Signed-off-by: Albin Kerouanton <[email protected]>
This looks fine. Swarm is just plumbing this field down, and the hard work is all handled in the Engine. Nota bene, @akerouanton, that the |
Includes moby/swarmkit#2967, which adds Ulimits to ContainerSpec. Signed-off-by: Albin Kerouanton <[email protected]>
Includes moby/swarmkit#2967, which adds Ulimits to ContainerSpec. Signed-off-by: Albin Kerouanton <[email protected]> Upstream-commit: 1fdb1033c4cecbd589fa6afa5b7a975bbaf712e4 Component: engine
- What I did
Unlike Docker and docker-compose, Swarm never supported ulimits.
This change introduces a new Ulimits field on the ContainerSpec type. It
can be used by API clients to set desired ulimits.
This is related to moby/moby#40639.
- How to test it
- Description for the changelog
Add Ulimits field to the API