Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor allocator to attempt to reduce complexity #2823

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 9, 2019

This one is built on top of #2821

see individual commits for a description of the changes 🤗

@thaJeztah
Copy link
Member Author

@dperny @andrey-ko PTAL

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #2823 into master will increase coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2823      +/-   ##
==========================================
+ Coverage   61.62%   61.67%   +0.05%     
==========================================
  Files         139      139              
  Lines       22615    22612       -3     
==========================================
+ Hits        13936    13947      +11     
+ Misses       7194     7185       -9     
+ Partials     1485     1480       -5

@thaJeztah
Copy link
Member Author

rebased to kick CI again

@thaJeztah
Copy link
Member Author

rebased again

@thaJeztah
Copy link
Member Author

ping @dani-docker @dperny ptal

@dani-docker
Copy link
Contributor

All 3 LGTM 👍

@thaJeztah
Copy link
Member Author

@dperny ptal

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Merging #2823 (b0ee1de) into master (b98a45d) will increase coverage by 0.04%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master    #2823      +/-   ##
==========================================
+ Coverage   61.75%   61.79%   +0.04%     
==========================================
  Files         155      155              
  Lines       31145    31138       -7     
==========================================
+ Hits        19234    19243       +9     
+ Misses      10361    10349      -12     
+ Partials     1550     1546       -4     

@thaJeztah thaJeztah force-pushed the reduce_allocator_complexity branch from 68c710d to 8a13d59 Compare July 29, 2023 08:40
@thaJeztah thaJeztah force-pushed the reduce_allocator_complexity branch from 8a13d59 to b0ee1de Compare July 29, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants