Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle signals #214

Closed
creack opened this issue Mar 27, 2013 · 0 comments
Closed

Handle signals #214

creack opened this issue Mar 27, 2013 · 0 comments

Comments

@creack
Copy link
Contributor

creack commented Mar 27, 2013

Since we made the raw mode working, the signals are completely ignored.

As this is not mandatory in order to use a shell, We should catch the signals and kill the client (resulting in detaching any attached containers)
creack added a commit that referenced this issue Mar 27, 2013
@creack
#214 Better signal handling,
1f7f6fd
@creack creack mentioned this issue Mar 27, 2013
Merged
creack added a commit that referenced this issue Mar 28, 2013
@creack
#214 Better signal handling
108acc0
@creack creack mentioned this issue Mar 30, 2013
Closed
@creack creack closed this as completed Mar 30, 2013
rtyler pushed a commit to rtyler/docker that referenced this issue Feb 23, 2018
@carlossg
Merge pull request moby#214 from dhrapson/master
9b2d222 
replace hard-coded /var/jenkins_home with $JENKINS_HOME
AkihiroSuda pushed a commit to AkihiroSuda/docker that referenced this issue May 16, 2019
@andrewhsu
Merge pull request moby#214 from thaJeztah/19.03_backport_log-daemon-…
ff44133 
…exit-before-tests-finish

[19.03 backport] Ensure all integration daemon logging happens before test exit
enool added a commit to enool/term that referenced this issue Oct 4, 2022
@enool
term: remove interrupt handler on termios
24def99 
On termios platforms, interrupt signals are not generated in raw mode
terminals as the ISIG setting is not enabled. Remove interrupt handler
as it does nothing for raw mode and prevents other uses of INT signal
with this library.

This code seems to go back all the way to moby/moby#214 where signal
handling was improved for monolithic docker repository. Raw mode !ISIG
was later added back in 3f63b878076 ("Disable signal catching and enable
real posix raw mode"), but INT handler was never removed.

Signed-off-by: Sami Loone <[email protected]>
enool added a commit to enool/term that referenced this issue Oct 4, 2022
@enool
term: remove interrupt handler on termios
e2ec702 
On termios platforms, interrupt signals are not generated in raw mode
terminals as the ISIG setting is not enabled. Remove interrupt handler
as it does nothing for raw mode and prevents other uses of INT signal
with this library.

This code seems to go back all the way to moby/moby#214 where signal
handling was improved for monolithic docker repository. Raw mode ISIG
was again later removed in 3f63b878076 ("Disable signal catching and
enable real posix raw mode"), but INT handler was left behind.

Signed-off-by: Sami Loone <[email protected]>
enool added a commit to enool/term that referenced this issue Oct 4, 2022
@enool
term: remove interrupt handler on termios
2975884 
On termios platforms, interrupt signals are not generated in raw mode
terminals as the ISIG setting is not enabled. Remove interrupt handler
as it does nothing for raw mode and prevents other uses of INT signal
with this library.

This code seems to go back all the way to moby/moby#214 where signal
handling was improved for monolithic docker repository. Raw mode -ISIG
got reintroduced in 3f63b878076 ("Disable signal catching and enable
real posix raw mode"), but the INT handler was left behind.

Signed-off-by: Sami Loone <[email protected]>
enool added a commit to enool/term that referenced this issue Oct 4, 2022
@enool
term: remove interrupt handler on termios
94b314a 
On termios platforms, interrupt signals are not generated in raw mode
terminals as the ISIG setting is not enabled. Remove interrupt handler
as it does nothing for raw mode and prevents other uses of INT signal
with this library.

This code seems to go back all the way to moby/moby#214 where signal
handling was improved for monolithic docker repository. Raw mode -ISIG
got reintroduced in moby/moby@3f63b878076, but the INT handler was left
behind.

Signed-off-by: Sami Loone <[email protected]>
@enool enool mentioned this issue Oct 4, 2022
Merged
thaJeztah added a commit to thaJeztah/cli that referenced this issue Nov 5, 2022
@thaJeztah
vendor: update github.com/moby/sys to fix interrupt handling
adccf85 
On termios platforms, interrupt signals are not generated in raw mode terminals
as the ISIG setting is not enabled. Remove interrupt handler as it does nothing
for raw mode and prevents other uses of INT signal with this library.

This code seems to go back all the way to moby/moby#214 where signal handling was
improved for monolithic docker repository. Raw mode -ISIG got reintroduced in
moby/moby@3f63b878076, but the INT handler was left
behind.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah mentioned this issue Nov 5, 2022
Merged
thaJeztah added a commit to thaJeztah/cli that referenced this issue Nov 28, 2022
@thaJeztah
vendor: update github.com/moby/sys to fix interrupt handling
5a86e4f 
On termios platforms, interrupt signals are not generated in raw mode terminals
as the ISIG setting is not enabled. Remove interrupt handler as it does nothing
for raw mode and prevents other uses of INT signal with this library.

This code seems to go back all the way to moby/moby#214 where signal handling was
improved for monolithic docker repository. Raw mode -ISIG got reintroduced in
moby/moby@3f63b878076, but the INT handler was left
behind.

full diff: moby/term@abb1982...c43b287

Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah added a commit to thaJeztah/cli that referenced this issue Nov 28, 2022
@thaJeztah
vendor: update github.com/moby/term to fix interrupt handling
536aef9 
On termios platforms, interrupt signals are not generated in raw mode terminals
as the ISIG setting is not enabled. Remove interrupt handler as it does nothing
for raw mode and prevents other uses of INT signal with this library.

This code seems to go back all the way to moby/moby#214 where signal handling was
improved for monolithic docker repository. Raw mode -ISIG got reintroduced in
moby/moby@3f63b878076, but the INT handler was left
behind.

full diff: moby/term@abb1982...c43b287

Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah added a commit to thaJeztah/docker that referenced this issue Dec 5, 2022
@thaJeztah
vendor: github.com/moby/term v0.0.0-20221205130635-1aeaba878587
9c7d594 
term: remove interrupt handler on termios

On termios platforms, interrupt signals are not generated in raw mode
terminals as the ISIG setting is not enabled. Remove interrupt handler
as it does nothing for raw mode and prevents other uses of INT signal
with this library.

This code seems to go back all the way to moby#214 where signal
handling was improved for monolithic docker repository. Raw mode -ISIG
got reintroduced in moby/moby@3f63b878076, but the INT handler was left
behind.

full diff: moby/term@abb1982...1aeaba8

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah mentioned this issue Dec 5, 2022
Merged
thaJeztah added a commit to thaJeztah/docker that referenced this issue Apr 30, 2023
@thaJeztah
vendor: github.com/moby/term v0.0.0-20221205130635-1aeaba878587
c1d420e 
term: remove interrupt handler on termios

On termios platforms, interrupt signals are not generated in raw mode
terminals as the ISIG setting is not enabled. Remove interrupt handler
as it does nothing for raw mode and prevents other uses of INT signal
with this library.

This code seems to go back all the way to moby#214 where signal
handling was improved for monolithic docker repository. Raw mode -ISIG
got reintroduced in moby/moby@3f63b878076, but the INT handler was left
behind.

full diff: moby/term@abb1982...1aeaba8

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@creack