Add an explicit flag to join network in diagnostic #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcrisciani
force-pushed
the
join-flag
branch
from
e32f826 to
09703dd
Compare
ddebroy
approved these changes
Feb 23, 2018
| networkPeers = fetchNodePeers(*ipPtr, *portPtr, *networkPtr) | ||
| joinedNetwork = true | ||
| if len(networkPeers) == 0 { | ||
| logrus.Warnf("There is no peer on network %q, check the network ID, and verify that is the non truncated version", *networkPtr) |
There was a problem hiding this comment.
Is it safe to continue here rather than exit with fatalf?
There was a problem hiding this comment.
yep it is, the output will only show no peers on the network and the validation with the entries will show a warning like:
WARN[0000] The element with key:23591a2e3795dc36c994eae6074239c91a9e647784af374cea1abf33373acb07 does not belong to any node on this network
Codecov Report
@@ Coverage Diff @@
## master #2087 +/- ##
=========================================
Coverage ? 40.39%
=========================================
Files ? 139
Lines ? 22352
Branches ? 0
=========================================
Hits ? 9028
Misses ? 11997
Partials ? 1327Continue to review full report at Codecov.
|
fcrisciani
force-pushed
the
join-flag
branch
from
09703dd to
01c9b8a
Compare
ddebroy
approved these changes
Feb 23, 2018
cmd/diagnostic/README.md
Outdated
| @@ -199,8 +199,18 @@ The following flags are supported: | |||
| | -ip <string> | The IP address to query. Defaults to 127.0.0.1. | | |||
| | -net <string> | The target network ID. | | |||
| | -port <int> | The target port. (default port is 2000) | | |||
| | -a | join/leave network | | |||
There was a problem hiding this comment.
Just a minor nit: change join to Join to align with the descriptions above and below.
fcrisciani
force-pushed
the
join-flag
branch
from
01c9b8a to
acff1b5
Compare
Usually a diagnostic session wants to check the local state without this flag the network is joined and left every iteration altering actually the daemon status. Also if the diagnostic client is used against a live node, the network leave has a very bad side effect of kicking the node out of the network killing its internal status. For the above reason introducing the flag -a to be explicit so that the current state is always preserved Signed-off-by: Flavio Crisciani <[email protected]>
fcrisciani
force-pushed
the
join-flag
branch
from
acff1b5 to
47c28fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually a diagnostic session wants to check the local state
without this flag the network is joined and left every iteration
altering actually the daemon status.
Also if the diagnostic client is used against a live node, the
network leave has a very bad side effect of kicking the node
out of the network killing its internal status.
For the above reason introducing the flag -a to be explicit
so that the current state is always preserved
Signed-off-by: Flavio Crisciani [email protected]