Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle containers with different network drivers #1480

Merged
merged 1 commit into from
Oct 26, 2016
Merged

Conversation

pooya
Copy link
Contributor

@pooya pooya commented Sep 29, 2016

There is no guarantees that the ep and extEp are using the same driver.
If they are not using the same drivers, the driver for ep will not know
about the networks of extEp and fails the RevokeExternalConnectivity
call.

Signed-off-by: Shayan Pooya [email protected]

@aboch
Copy link
Contributor

aboch commented Oct 3, 2016

Thank you for finding this and your contribution.

I think the same applies in the sbLeave() at

    // New endpoint providing external connectivity for the sandbox
    extEp = sb.getGatewayEndpoint()
    if moveExtConn && extEp != nil {
        log.Debugf("Programming external connectivity on endpoint %s (%s)", extEp.Name(), extEp.ID())
        if err := d.ProgramExternalConnectivity(extEp.network.ID(), extEp.ID(), sb.Labels()); err != nil {
            log.Warnf("driver failed programming external connectivity on endpoint %s: (%s) %v",
                extEp.Name(), extEp.ID(), err)
        }
    }

@pooya
Copy link
Contributor Author

pooya commented Oct 6, 2016

Thanks @aboch . Amended the commit to include a fix for the issue in sbLeave().
However, looks like there are some issues with the dependencies, I'll rebase on master and repush.

There is no guarantees that the ep and extEp are using the same driver.
If they are not using the same drivers, the driver for ep will not know
about the networks of extEp and fails the RevokeExternalConnectivity
call.

Signed-off-by: Shayan Pooya <[email protected]>
@aboch
Copy link
Contributor

aboch commented Oct 7, 2016

Thanks for this fix.
Tested it.

LGTM

@aboch aboch merged commit 3e6303f into moby:master Oct 26, 2016
runcom pushed a commit to runcom/docker that referenced this pull request May 1, 2017
Upstream reference: moby/libnetwork#1480
Fix BZ#1446526

There is no guarantees that the ep and extEp are using the same driver.
If they are not using the same drivers, the driver for ep will not know
about the networks of extEp and fails the RevokeExternalConnectivity
call.

Signed-off-by: Shayan Pooya <[email protected]>
Signed-off-by: Antonio Murdaca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants