-
Notifications
You must be signed in to change notification settings - Fork 1.3k
dockerfile: promote --parents flag from labs #6282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7e47318 to
87e7250
Compare
5c0cf2f to
8a78533
Compare
b5cf692 to
e7b2c0c
Compare
cache/contenthash/checksum.go
Outdated
|
|
||
| // Validate that all required paths exist. | ||
| for _, requiredPath := range opts.RequiredPaths { | ||
| requiredPath = filepath.ToSlash(requiredPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this would be the right place for such fix. General rule is that LLB layer should have all the paths already in unix-style. If the client is working with Windows paths, then they convert them to Unix before LLB marshal, and if the wcow daemon needs a Windows path for local file operations, then they convert it from Unix to the local format.
cc @profnandaa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to have worked anyway.
e7b2c0c to
2670f2a
Compare
|
Switching this to draft until I fix the windows test. It appears we didn't run the labs tests on windows so this popped up here instead. |
2670f2a to
bf172e6
Compare
|
I made changes for normalizing the file path but when I attempted to update the integration test to work on Windows I didn't find any other examples of writing a windows command prompt test in such a way so I marked it as skipped for now. Similar tests were also skipped on Windows. |
|
cc @rzlink |
bf172e6 to
f26e9ee
Compare
be93820 to
5ad85a8
Compare
08a1617 to
752d3af
Compare
f2dea0c to
ec04db4
Compare
|
@profnandaa @rzlink I'm having some issues trying to get a windows version of this test working. I'm getting this error: a decent amount I assumed it had something to do with the container user so I tried changing the user to |
Signed-off-by: Jonathan A. Sternberg <[email protected]>
ec04db4 to
98d0a0a
Compare
No description provided.