-
Notifications
You must be signed in to change notification settings - Fork 1.3k
solver: Resolve infinite loop when record is ErrNotFound #6186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solver: Resolve infinite loop when record is ErrNotFound #6186
Conversation
|
This |
|
@thaJeztah are these test failures real or flakes? |
|
Oh; honestly, don't know! I'm not a core maintainer of BuildKit (but have permission in the org, so thought I'd give CI a nudge on your PR to let it run 🤗) |
|
@thaJeztah Looks like they are flakes, but tests passed now |
|
@tonistiigi, may we have a review on this. We found this issue on our ci build system at nvidia and are running it in a patched version of 0.23. |
dc9b827 to
318b6fc
Compare
tonistiigi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we don't allow such tests with mocks as they would likely just break in any internal code change. If you can't figure out the conditions for an integration test, then just remove the new test you added.
|
@tonistiigi got it, removing the test. |
|
Squash the commits as well. |
|
@tonistiigi I uploaded a better test that didn't rely on the mocks. Still correctly tests the ErrNotFound infinite loop. Will Squash the commits now. |
- Align record selected for export with the record used for alternatives - Add integration test for ExportTo ErrNotFound Signed-off-by: Sam Oluwalana <[email protected]>
849bcde to
f7639d8
Compare
|
@tonistiigi / @thaJeztah could one of you restart the tests that couldn't acquire resources? |
|
When can we expect this to be released as a bug fix patch? :) |
This MR resolves the following situation:
i,addRecordorexportRecordAlso adds a test to the exporter. The added test will hit the infinite loop without the changes in exporter.go.