dockerfile: fix client init in testGitQueryString #6179
Merged
+1
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <[email protected]>
crazy-max
commented
Sep 1, 2025
| f := getFrontend(t, sb) | ||
|
|
||
| subModDir := t.TempDir() | ||
| defer os.RemoveAll(subModDir) |
Member
Author
There was a problem hiding this comment.
This is not needed, t.TempDir() is removed when test is completed.
crazy-max
added
needs-cherry-pick/v0.23
needs-cherry-pick/v0.24
and removed
needs-cherry-pick/v0.23
labels
thaJeztah
reviewed
Sep 1, 2025
Comment on lines
-643
to
-645
| cl, err := client.New(sb.Context(), sb.Address()) | ||
| require.NoError(t, err) | ||
| defer c.Close() |
Member
There was a problem hiding this comment.
This was the actual fix, correct? I was trying to find where the deadlock was, but I guess somewhere in the client.New constructor?
Or is it related to the grpc.DialContext ?
Lines 154 to 157 in 9fcedf9
Member
Author
There was a problem hiding this comment.
Actual fix is cl is not closed so on line 645 defer cl.Close() would work but then cl.Prune later would be useless so we need to reuse the same client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to moby/moby#50858