git: fix subdir filter on submodule dir #6170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because subdir filter happened before the submodule update it resulted in empty directory being filtered and submodule update being skipped because .gitmodules was already missing. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
git-submodule-filter
branch
from
7c82f1c to
cf599d4
Compare
Member
|
Small lint issue https://github.com/moby/buildkit/actions/runs/17288544271/job/49070427745?pr=6170#step:3:469 otherwise LGTM Edit: Nevermind you just fixed it 😅 |
crazy-max
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because subdir filter happened before submodule update it resulted in empty directory being filtered and submodule update being skipped because .gitmodules was already missing.
fix #6138