mv util/gitutil/git_ref.go frontend/dockerfile/dfgitutil/git_ref.go #6152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dockerfile
area/testing
area/frontend
area/util
area/solver
labels
The `ParseGitRef` function was only used in `frontend/{dockerfile, dockerui}`,
expect a single occurrence in `solver/llbsolver/history.go`.
The occurrence in `solver/llbsolver/history.go` now uses
`util/gitutil/git_url.go:ParseURL()`.
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
decouple-git_ref
branch
from
86e5be1 to
2207a88
Compare
tonistiigi
approved these changes
Aug 21, 2025
crazy-max
approved these changes
Aug 21, 2025
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
The
ParseGitReffunction was only used infrontend/{dockerfile, dockerui},
We are calling this func on Buildx repo https://github.com/search?q=repo%3Adocker%2Fbuildx%20gitutil.ParseGitRef&type=code but looking at it I think we can use ParseURL instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ParseGitReffunction was only used infrontend/{dockerfile, dockerui}, expect a single occurrence insolver/llbsolver/history.go.The occurrence in
solver/llbsolver/history.gonow usesutil/gitutil/git_url.go:ParseURL().