Use commit date in release binary artifacts #6037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the commit date of the HEAD commit as date for the release binary artifacts date maintaining determinism but being realistic. Previously, a constant `2015-10-21 00:00Z` was used. Fixes moby#2007 Signed-off-by: Alberto Contreras <[email protected]>
Author
|
I have tested it by: make release # with containerd-snapshtter set as true
$ git show -s --format='%cI' HEAD
2025-06-18T18:38:27+02:00
$ tar tavf bin/release/buildkit-v0.23.0-rc1-5-gdb4643606.linux-amd64.tar.gz
drwxr-xr-x root/root 0 2025-06-18 18:38 bin/
-rwxr-xr-x root/root 33414304 2025-06-18 18:38 bin/buildctl
-rwxr-xr-x root/root 5694447 2025-06-18 18:38 bin/buildkit-cni-bridge
-rwxr-xr-x root/root 5749447 2025-06-18 18:38 bin/buildkit-cni-firewall
...
# both dates are aligned
rm -rv bin/release/* # and repeat the process, verify the date is still the same |
tonistiigi
approved these changes
Jun 18, 2025
AkihiroSuda
approved these changes
Jun 20, 2025
crazy-max
previously approved these changes
Jun 20, 2025
Member
|
Seems tarball is not created 🤔: https://github.com/moby/buildkit/actions/runs/15738588557/job/44462990343?pr=6037#step:3:16 Maybe artifacts got pruned when re-running the workflow. Let me do a full re-run to make sure. |
crazy-max
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the commit date of the HEAD commit as date for the release binary artifacts date maintaining determinism but being realistic.
Previously, a constant
2015-10-21 00:00Zwas used.Fixes #2007
Signed-off-by: Alberto Contreras [email protected]