Skip to content

Conversation

@tonistiigi
Copy link
Member

based on #5907

Expose the existing Gateway API file access function to the
session exporter callback so it can make better decisions.

@tonistiigi
Copy link
Member Author

@profnandaa The test failed on windows

    client_test.go:2365: readdir: entries:{path:"License.txt"  mode:493  size:5647  modTime:1741256959331475600}  entries:{path:"ProgramData"  mode:2147484141  modTime:1620456191021041900}  entries:{path:"System Volume Information"  mode:2147484141  modTime:1744353880328676500}  entries:{path:"Users"  mode:2147484013  modTime:1741257047315557900}  entries:{path:"WcSandboxState"  mode:2147484141  modTime:1744353880328676500}  entries:{path:"Windows"  mode:2147484141  modTime:1741257054706187200}  entries:{path:"bar"  mode:493  size:9  modTime:1744353893740354600}  entries:{path:"foo"  mode:493  size:8  modTime:1744353888451985500}
    client_test.go:2396: 
        	Error Trace:	D:/a/buildkit/buildkit/client/client_test.go:2396
        	            				D:/a/buildkit/buildkit/util/testutil/integration/run.go:103
        	            				D:/a/buildkit/buildkit/util/testutil/integration/run.go:245
        	Error:      	Received unexpected error:
        	            	failed to open writer: ref buildkit/1/n1ataygfvdpsnxi8yygvwb9u1 locked for 136.7176ms (since 2025-04-11 06:44:54.4128669 +0000 UTC m=+21.478406301): unavailable

Not sure why though. It didn't look like the actual export path was failing, but the Build() function itself. I disabled the WCOW test for now.

@profnandaa
Copy link
Collaborator

ACK, will take a look.

@tonistiigi tonistiigi force-pushed the session-exporter-ref-access branch from 08ed38f to 591b25a Compare April 11, 2025 14:40
@tonistiigi tonistiigi marked this pull request as ready for review April 11, 2025 14:40
@github-actions github-actions bot removed the area/api label Apr 11, 2025
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit otherwise LGTM

Expose existing Gateway API file access function to the
session exporter callback so it can make better decisions.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi force-pushed the session-exporter-ref-access branch from 591b25a to c66c687 Compare April 11, 2025 14:54
@crazy-max crazy-max added this to the v0.21.0 milestone Apr 11, 2025
@crazy-max crazy-max merged commit 50851da into moby:master Apr 11, 2025
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants