fix: set h2 protocol identifier to comply with TLS-ALPN #5413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to bump
grpc-go
(in this repo or in external clients) we need to specifyh2
as the application protocol in buildkitd's TLS config.The enforcement was introduced in
grpc-go v1.67.0
.buildkit
andbuildx
are currently onv1.66.2
so this patch is needed for the next update. I didn't updategrpc-go
in this patch, but can do if you prefer.Testing with
buildctl
onv1.67.1
Before this patch
After patch
Context