-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: frontend/dockerfile: update integration tests for windows/wcow (part 4) #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready for reviews |
billywr
force-pushed
the
wcow-integration-test-part-4
branch
from
September 24, 2024 06:42
813163a
to
0e0a6b2
Compare
billywr
force-pushed
the
wcow-integration-test-part-4
branch
9 times, most recently
from
September 25, 2024 05:05
cdb907d
to
8e38ee4
Compare
billywr
force-pushed
the
wcow-integration-test-part-4
branch
from
September 25, 2024 05:52
8e38ee4
to
841c0ca
Compare
billywr
force-pushed
the
wcow-integration-test-part-4
branch
4 times, most recently
from
September 26, 2024 06:26
df56a39
to
b8d3322
Compare
billywr
force-pushed
the
wcow-integration-test-part-4
branch
7 times, most recently
from
October 2, 2024 06:53
3b780c4
to
70ccac5
Compare
billywr
force-pushed
the
wcow-integration-test-part-4
branch
3 times, most recently
from
October 8, 2024 05:59
53a5fa3
to
fbf440e
Compare
billywr
force-pushed
the
wcow-integration-test-part-4
branch
from
October 8, 2024 06:10
fbf440e
to
382ecfb
Compare
profnandaa
suggested changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can just fix those, the rest should be good with me.
billywr
force-pushed
the
wcow-integration-test-part-4
branch
4 times, most recently
from
October 23, 2024 13:49
53f4487
to
245d957
Compare
…dows. Partially addressing moby#4485 Signed-off-by: Billy Owire <[email protected]>
billywr
force-pushed
the
wcow-integration-test-part-4
branch
from
October 23, 2024 14:30
245d957
to
8e5c34f
Compare
profnandaa
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
tonistiigi
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated tests in frontend/dockerfile/dockerfile_test.go to run on Windows.
Partially addressing #4485