Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: frontend/dockerfile: update integration tests for windows/wcow (part 4) #5350

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

billywr
Copy link

@billywr billywr commented Sep 24, 2024

Updated tests in frontend/dockerfile/dockerfile_test.go to run on Windows.
Partially addressing #4485

  • testMultiStageImplicitFrom
  • testMultiStageCaseInsensitive
  • testOnBuildCleared
  • testBuiltinArgs
  • testFrontendUseForwardedSolveResults
  • testDockerfileAddArchive
  • testCopyWildcardCache

@billywr
Copy link
Author

billywr commented Sep 24, 2024

ready for reviews

@billywr billywr force-pushed the wcow-integration-test-part-4 branch 9 times, most recently from cdb907d to 8e38ee4 Compare September 25, 2024 05:05
@billywr billywr force-pushed the wcow-integration-test-part-4 branch 4 times, most recently from df56a39 to b8d3322 Compare September 26, 2024 06:26
@billywr billywr force-pushed the wcow-integration-test-part-4 branch 7 times, most recently from 3b780c4 to 70ccac5 Compare October 2, 2024 06:53
@billywr billywr force-pushed the wcow-integration-test-part-4 branch 3 times, most recently from 53a5fa3 to fbf440e Compare October 8, 2024 05:59
@billywr billywr force-pushed the wcow-integration-test-part-4 branch from fbf440e to 382ecfb Compare October 8, 2024 06:10
@billywr billywr marked this pull request as ready for review October 9, 2024 08:41
Copy link
Collaborator

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just fix those, the rest should be good with me.

frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_test.go Show resolved Hide resolved
@billywr billywr force-pushed the wcow-integration-test-part-4 branch 4 times, most recently from 53f4487 to 245d957 Compare October 23, 2024 13:49
@billywr billywr force-pushed the wcow-integration-test-part-4 branch from 245d957 to 8e5c34f Compare October 23, 2024 14:30
Copy link
Collaborator

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@tonistiigi tonistiigi merged commit 076d69e into moby:master Oct 24, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants