remotecache: handle not implemented error for Info() #5257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
remotecache-not-implemented-err
branch
from
6d3f356
to
74b0515
Compare
thaJeztah
approved these changes
Aug 15, 2024
| @@ -281,7 +282,9 @@ func marshalRemote(ctx context.Context, r *solver.Remote, state *marshalState) s | |||
| if r.Provider != nil { | |||
| for _, d := range r.Descriptors { | |||
| if _, err := r.Provider.Info(ctx, d.Digest); err != nil { | |||
| return "" | |||
| if !cerrdefs.IsNotImplemented(err) { | |||
There was a problem hiding this comment.
For others; I was curious if this should be using buildkit's or moby's errdefs definitions, but the Provider.Info interface looks to be defined by containerd;
(wondering if GoDoc for the interface should also mention NotImplemented, but maybe it's not strictly how containerd expected that to be handled other than "don't implement the interface")
|
OH! Typo in the commit message; perhaps good to fix if you want to be able to find it back; |
Moby graphdriver backend does not implement Info() and such case should not be used as a signal for blob needed to be skipped as it is unavailable. This requires a change in Moby side as well to return a typed error instead of string. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
remotecache-not-implemented-err
branch
from
74b0515
to
8fdf84f
Compare
jedevc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5242
Moby graphdriver backend does not implement Info() and such case should not be used as a signal for
blob needed to be skipped as it is unavailable.
This requires a change in Moby side as well to return a typed error instead of string.