chore: set pb.Empty on ssh and secret mounts
#5252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These mounts have no vertex inputs, and so should be *explicitly* marshaled as such. Signed-off-by: Justin Chadwell <[email protected]>
jedevc
changed the title
pb.Empty on ssh and secret mounts
crazy-max
approved these changes
Aug 13, 2024
tonistiigi
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5251 (comment).
These mounts have no vertex inputs, and so should be explicitly marshaled as such.
I think this is the "root cause" of docker/buildx#2479, but since marshaling is done on the client, #5251 is still required. However, the client should explicitly indicate that there is no vertex input on these special mount types.