-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add OCI image annotations to Dockerfile frontend images #5197
Conversation
Signed-off-by: Craig Andrews <[email protected]>
@crazy-max how's this PR look? |
@crazy-max friendly bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes so we can verify this on PR like the BuildKit image
Co-authored-by: CrazyMax <[email protected]> Signed-off-by: Craig Andrews <[email protected]>
Co-authored-by: CrazyMax <[email protected]> Signed-off-by: Craig Andrews <[email protected]>
Thank you, those changes look good to me and have been applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
See: https://github.com/opencontainers/image-spec/blob/main/annotations.md#pre-defined-annotation-keys
Closes: #3553
Signed-off-by: Craig Andrews [email protected]