buildkitd: use default config file location when run as root in rootless #4368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
approved these changes
Oct 24, 2023
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM, but probably we should have sync.Once
When running buildkitd in a rootless environment but as root, buildkitd misinterprets how it is being run and loads the config file from the home directory instead of the global location in `/etc/buildkitd`. This happens when buildkit is being run in docker and docker itself is being run as rootless. The buildkit daemon sees the user remapping and assumes that the remapping belongs to itself rather than to docker. This causes it to load the wrong configuration file as buildkitd is still being run as "root" but a remapped root that docker created. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
default-config-within-rootless-docker
branch
from
005c39c to
bb8f9f7
Compare
Collaborator
Author
|
@AkihiroSuda done. |
tonistiigi
approved these changes
Oct 24, 2023
Member
|
This failure again https://github.com/moby/buildkit/actions/runs/6629234136/job/18008162650?pr=4368#step:5:47. 15min timeout still doesn't look enough 😣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running buildkitd in a rootless environment but as root, buildkitd
misinterprets how it is being run and loads the config file from the
home directory instead of the global location in
/etc/buildkitd.This happens when buildkit is being run in docker and docker itself is
being run as rootless. The buildkit daemon sees the user remapping and
assumes that the remapping belongs to itself rather than to docker.
This causes it to load the wrong configuration file as buildkitd is
still being run as "root" but a remapped root that docker created.
Related to docker/buildx#2092.