docs/build-repro.md: fix description about squashing #3980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2023
Member
|
@AkihiroSuda Should we add some flag that allows setting timestamp(either to value or to epoch) during |
Member
Author
👍, but many Dockerfiles will still need squashing |
tonistiigi
reviewed
Jul 6, 2023
Member
Can you send a PR? |
Member
Author
Sorry, I'm on PTO and missed this for v0.12 |
We can't avoid squashing even after just fixing up whiteout timestamps; Squashing is still needed to apply the `touch`-ed timestamps across multiple `RUN` instructions. Squashing will no longer be needed if we can merge PR 3560. Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
fix-repro-workarounds-description
branch
from
a3b3c76 to
0758355
Compare
Member
Author
|
ping @tonistiigi |
tonistiigi
approved these changes
Aug 3, 2023
This was referenced Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't avoid squashing even after just fixing up whiteout timestamps (#3560 (comment)) ; Squashing is still needed to apply the
touch-ed timestamps across multipleRUNinstructions.Squashing will no longer be needed if we can merge: