ci: output annotations for failures#3727
Merged
Merged
Conversation
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
commented
Mar 18, 2023
| uses: actions/github-script@v6 | ||
| name: Generate annotations | ||
| if: always() | ||
| uses: crazy-max/.github/.github/actions/gotest-annotations@main |
Member
Author
There was a problem hiding this comment.
Using a remote composite action to reduce dedup. Will use a commit sha if we are ok with this implementation.
See https://github.com/crazy-max/.github#gotest-annotations
AkihiroSuda
approved these changes
Mar 20, 2023
tonistiigi
approved these changes
Mar 20, 2023
Atm it's not easy to go through the logs and quickly find what tests are currently failing. With this change we'll have GitHub annotations for failed tests directly reported in the pull request. Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
test-annotations
branch
from
55af34f to
65540db
Compare
jedevc
approved these changes
Mar 20, 2023
Member
Author
|
Hum there's smth odd going on. https://github.com/moby/buildkit/actions/runs/4466712165/jobs/7845304694#step:7:1455 fails and annotation is generated but GitHub checks is green 🤔. Will look at this. Edit: That's fine, we continue-on-error for nydus integration tests: buildkit/.github/workflows/.test.yml Line 144 in 170e440 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #2900 and #3411
Atm it's not easy to go through the logs and quickly find what tests are currently failing.
With this change we'll have GitHub annotations for failed tests directly reported in "Files changed" for a pull request.
Tested here: https://github.com/crazy-max/buildkit/pull/12/files