rootless: support Bottlerocket OS #3697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
fix-3098
branch
2 times, most recently
from
611f84b to
42aa562
Compare
Port https://github.com/moby/moby/blob/v23.0.1/daemon/oci_linux.go#L430-L460 > // Get the set of mount flags that are set on the mount that contains the given > // path and are locked by CL_UNPRIVILEGED. This is necessary to ensure that > // bind-mounting "with options" will not fail with user namespaces, due to > // kernel restrictions that require user namespace mounts to preserve > // CL_UNPRIVILEGED locked flags. Fix issue 3098 Signed-off-by: Akihiro Suda <[email protected]>
…ces=N`) Signed-off-by: Akihiro Suda <[email protected]>
tonistiigi
approved these changes
Mar 11, 2023
arnaldo2792
reviewed
Mar 11, 2023
| ### Bottlerocket OS | ||
| Needs to run `sysctl -w user.max_user_namespaces=N` (N=positive integer, like 63359) on the host nodes. |
Contributor
There was a problem hiding this comment.
Running this command in the Bottlerocket hosts isn't the recommended approach, I can update the docs to mention how to set up max_user_namespaces in the “Bottlerocket way”, if that's OK with you all.
There was a problem hiding this comment.
Where is the documentation about this theme guys?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3098
Tested on Bottlerocket OS 1.12.0 (aws-k8s-1.25), kernel 5.15.79 (
eksctl --version=1.25 -node-ami-family=Bottlerocketusing eksctl 0.132.0)