[0.10] git context: fix support for empty git ref with subdir#3603
Closed
crazy-max wants to merge 3 commits into
Closed
[0.10] git context: fix support for empty git ref with subdir#3603crazy-max wants to merge 3 commits into
crazy-max wants to merge 3 commits into
Conversation
partial cherry picked from commit 8bfeafa Co-authored-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit b5c9183)
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit 6a2287e)
crazy-max
changed the title
Member
Author
|
Acutally no need any backport to v0.10 branch as this regression has been introduced in v0.11 through #2799. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of:
ADD <git ref>#2799 (partially)I just take partial changes from #2799 to have the git context parsing logic from gitutil package. I could just avoid any backport and directly fix on v0.10 branch if you want. Let me know what sounds best.