remove buildinfo

[crazy-max]

follow-up #3614

v0.11 is released so we can remove build information implementation on master branch.

[AkihiroSuda]

buildinfo=false should be still valid for compatibility reason

[crazy-max]

By "valid" you mean should not fail when exporting?

[AkihiroSuda]

Yes

[crazy-max]

It does not afaik:

$ docker buildx build --output type=docker,buildinfo=false .
...
#34 [binaries-linux 4/4] COPY --link --from=buildkitd /usr/bin/buildkitd /
#34 merging 0.1s done
#34 DONE 0.2s

#35 [buildkit-linux 1/1] COPY --link --from=binaries / /usr/bin/
#35 DONE 0.2s

#36 exporting to docker image format
#36 exporting layers
#36 exporting layers 3.7s done
#36 exporting manifest sha256:26bff5cd69b2f771dad27d23b2c62c56377d6e8b91e4528b4af0f6bc9e4504e8 0.0s done
#36 exporting config sha256:e790b681a392ef3add1e375eda8fe35885ffb6ecd1f351dba3152169f7f22fdb 0.0s done
#36 sending tarball
#36 sending tarball 1.0s done
#36 DONE 4.7s

#37 importing to docker
#37 DONE 0.7s

See

buildkit/exporter/containerimage/opts.go

Lines 72 to 74 in faaa836

	default:
	rest[k] = v
	}

[thaJeztah]

SGTM, but not too familiar with this.

Do current versions print a warning if someone is using this?

[jedevc]

r.e. warnings - there is no warning as of now. We could add a warning to the v0.11 release branch, but I'm not convinced it's worth it.

One of the main reasons for the removal of the feature is that not really anyone uses it AFAIK.