Various exporter refactoring fixes#3465
Merged
jedevc merged 3 commits intomoby:masterfrom May 30, 2023
Merged
Conversation
Member
Author
|
@tonistiigi had a glance through this, these fixups still apply I think. It's just about refactoring some various little bits in the local and tar exporter, to make the style more similar to the containerimage exporters, and removing some unused option from the tar exporter. Not something we need, but we might as well take it for the milestone ❤️ |
tonistiigi
approved these changes
May 23, 2023
| if err != nil { | ||
| return nil, err | ||
| } | ||
| _ = opt |
Signed-off-by: Justin Chadwell <me@jedevc.com>
This allows one implementation for all the opts parsing, similar to how we do today for the ImageCommitOpts. Signed-off-by: Justin Chadwell <me@jedevc.com>
This option looks like a mistake added in 45fc3ed. These options aren't ever used, so we don't need to parse them, we can just silently discard them. Signed-off-by: Justin Chadwell <me@jedevc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out the various exporter fixups from #3403, since we won't merge new attestation options for now.