llbsolver: fix panic when requesting provenance on nil result#3462
Merged
jedevc merged 1 commit intomoby:masterfrom Jan 6, 2023
Merged
llbsolver: fix panic when requesting provenance on nil result#3462jedevc merged 1 commit intomoby:masterfrom
jedevc merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Merged
jedevc
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requesting provenance on build that returned
nilresulted in daemon panic.Theoretically, one could argue that even nil ref could have a provenance with frontend and build-arg names but trying to keep it turned out to be very complicated with a lot of functions needing exceptions as provenance is tracked per ref, not per result. If this becomes an issue somehow (are there any legit nil result builds?) then it can be revisited later. For now provenance is skipped for such builds, even if requested.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com