frontend: fix testMultiStageImplicitFrom to account for busybox changes#3436
Merged
crazy-max merged 1 commit intomoby:masterfrom Dec 27, 2022
Merged
frontend: fix testMultiStageImplicitFrom to account for busybox changes#3436crazy-max merged 1 commit intomoby:masterfrom
crazy-max merged 1 commit intomoby:masterfrom
Conversation
It looks like there's some changes between `busybox:1.34.0` and up; version
1.34.0 of the image did not have a `/usr/bin` directory (only `/usr/sbin`);
docker run --rm -it busybox:1.34.0 ls -al /usr/
total 12
drwxr-xr-x 3 root root 4096 Sep 13 2021 .
drwxr-xr-x 1 root root 4096 Dec 27 14:45 ..
drwxr-xr-x 2 daemon daemon 4096 Sep 13 2021 sbin
But 1.34.1 and up do;
docker run --rm -it busybox:1.34.1 ls -al usr/
total 16
drwxr-xr-x 4 root root 4096 Dec 21 18:28 .
drwxr-xr-x 1 root root 4096 Dec 27 14:44 ..
drwxr-xr-x 2 root root 4096 Dec 21 18:28 bin
drwxr-xr-x 2 daemon daemon 4096 Dec 21 18:28 sbin
It's not immediately apparent what caused this change, or if it's in
busybox itself, or in the official image only;
mirror/busybox@1_34_0...1_34_1
But either way, this change caused a test to fail:
sandbox.go:238: time="2022-12-27T13:45:25.294022820Z" level=debug msg="> creating 4gr5bno8rj7l3k7h9jxe3jhal [/bin/sh -c mkdir /usr/bin && echo -n foo > /usr/bin/go]" span="[golang 2/2] RUN mkdir /usr/bin && echo -n foo > /usr/bin/go"
sandbox.go:238: time="2022-12-27T13:45:25.433886983Z" level=debug msg="sandbox set key processing took 70.062631ms for container 5b4o358g2ryquk4s6ami38gqo"
sandbox.go:238: mkdir: can't create directory '/usr/bin': File exists
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was referenced Dec 27, 2022
Merged
Merged
crazy-max
approved these changes
Dec 27, 2022
Member
Author
|
Looks like it added a docker run --rm -it busybox:1.34.1 ls -al usr/bin/
total 8
drwxr-xr-x 2 root root 4096 Dec 21 18:34 .
drwxr-xr-x 4 root root 4096 Dec 21 18:34 ..
lrwxrwxrwx 1 root root 13 Dec 21 18:34 env -> ../../bin/env |
Member
Author
|
This one's green, @crazy-max - do you want a second review, or "good to go"? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like there's some changes between
busybox:1.34.0and up; version 1.34.0 of the image did not have a/usr/bindirectory (only/usr/sbin);But 1.34.1 and up do;
It's not immediately apparent what caused this change, or if it's in busybox itself, or in the official image only;
mirror/busybox@1_34_0...1_34_1
But either way, this change caused a test to fail: