Export attestations for tar exporter#3289
Merged
jedevc merged 3 commits intomoby:masterfrom Nov 28, 2022
Merged
Conversation
Member
Author
|
Marking as do-not-merge until #3197 is merged. |
jedevc
force-pushed
the
attestations-exporter-tar
branch
3 times, most recently
from
376300e to
0e791d2
Compare
This patch extracts the relevant filesystem generation logic that creates an fsutil.FS from a cache.ImmutableRef and associate attestations. Signed-off-by: Justin Chadwell <me@jedevc.com>
This connects the tar exporter and the local exporter to the same fileystem generation, similar to the approach followed by the shared ImageWriter used in both the containerimage and oci packages. This allows the tar exporter to use the same attestations generation logic, so attestations are now supported for the tar exporter. Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
attestations-exporter-tar
branch
from
0e791d2 to
aa76a1e
Compare
Member
Author
|
@tonistiigi have added this to the milestone, since it's just a re-org of the code from #3197, and can also close #3184 (which is already on the milestone). |
crazy-max
approved these changes
Nov 24, 2022
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
LGTM. As discussed let's look at the single/multi platform behavior in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⬆️ Follow-up to #3197
🛠️ Fixes #3184 by adding attestations to the tar exporter (local exporter support added in #3197).
This PR refactors the
tarexporter to share filesystem generation methods in common with thelocalexporter, which therefore lets it generate attestations in the same way.This refactor is similar to the
ImageWritercomponent shared between thecontainerimageandocipackages, except for this we have aCreateFSfunction for thelocalandtarpackages.