[v0.10 backport] rootless: support Google Container-Optimized OS #3151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile has `VOLUME /home/user/.local/share/buildkit` by default too, but the default VOLUME does not work with rootless on Google's Container-Optimized OS as it is mounted with `nosuid,nodev`. So the volume has to be explicitly mounted as an `emptyDir` volume. Tested with GKE Autopilot 1.24.3-gke.200 (kernel 5.10.123+, containerd 1.6.6). Fix issue 879 Thanks to Andrew Grigorev (ei-grad) and Ben Cressey (bcressey). Signed-off-by: Akihiro Suda <[email protected]> (cherry picked from commit b36488e) Signed-off-by: Akihiro Suda <[email protected]>
Member
|
Slightly confused: this is only updating documentation and examples, not really fixing an issue, correct? (no real objections, just wondering) |
Member
Author
Yes. |
crazy-max
approved these changes
Oct 5, 2022
thaJeztah
approved these changes
Oct 5, 2022
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Cherrypicked because users may not prefer using YAMLs in the master branch.
Thanks!
LGTM (not a maintainer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick (clean):
Options:[rbind ro]}]: operation not permittederrors) #3097