Skip to content

[v0.10 backport] update to Go 1.19#3146

Closed
thaJeztah wants to merge 12 commits into
moby:v0.10from
thaJeztah:0.10_update_go_version
Closed

[v0.10 backport] update to Go 1.19#3146
thaJeztah wants to merge 12 commits into
moby:v0.10from
thaJeztah:0.10_update_go_version

Conversation

@thaJeztah
Copy link
Copy Markdown
Member Author

We may need #2718 if the linter fails (let's see)

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Oct 4, 2022

Yup, looks like we do;

#13 111.8 client/ociindex/ociindex.go:5:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
#13 111.8 	"io/ioutil"
#13 111.8 	^

I could consider disabling that check as a "quick hack"; let me see

only a couple of conflicts, which were easy to solve, so I went ahead and included #2718

@thaJeztah thaJeztah force-pushed the 0.10_update_go_version branch from 5205714 to e56be95 Compare October 4, 2022 10:10
@thaJeztah thaJeztah marked this pull request as ready for review October 4, 2022 11:44
@thaJeztah
Copy link
Copy Markdown
Member Author

@crazy-max @tonistiigi @AkihiroSuda ptal

@thaJeztah
Copy link
Copy Markdown
Member Author

@crazy-max @tonistiigi @AkihiroSuda ptal 🙏

thaJeztah and others added 12 commits October 20, 2022 17:31
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 21e9e96)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The package has been deprecated since Go 1.16:

https://go.dev/doc/go1.16#ioutil

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 9bcd3f6)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Since go1.17 is set on all other containers, using go1.16
in only one pipeline can lead to unexpected behavior and
difference during test.

Signed-off-by: Vasek - Tom C <tom.chauveau@epitech.eu>
(cherry picked from commit 679b60c)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit ebdcd31)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 6676f30)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit a633fa4)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 8679e23)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit dec823f)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Pranav Pandit <pranavp@microsoft.com>
(cherry picked from commit 4ebb56e)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 1353f41)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 4a15e74)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit c175c93)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 0.10_update_go_version branch from e56be95 to 8a954bc Compare October 20, 2022 15:32
@AkihiroSuda
Copy link
Copy Markdown
Member

Needs rebase

@tonistiigi
Copy link
Copy Markdown
Member

(closing outdated backports)

@tonistiigi tonistiigi closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants