Added warning when using autorun + autorunAsync with an action (#576)

package.json

@@ -73,4 +73,4 @@
     "state management",
     "data flow"
   ]
-}
+}

src/api/autorun.ts

@@ -2,7 +2,7 @@ import {Lambda, getNextId, deprecated, invariant, valueDidChange} from "../utils
 import {assertUnwrapped, ValueMode, getValueModeFromValue} from "../types/modifiers";
 import {Reaction, IReactionPublic} from "../core/reaction";
 import {untrackedStart, untrackedEnd} from "../core/derivation";
-import {action} from "../api/action";
+import {action, isAction} from "../api/action";
 
 /**
  * Creates a reactive view and keeps it alive, so that the view is always
@@ -37,6 +37,10 @@ export function autorun(arg1: any, arg2: any, arg3?: any) {
 
 	assertUnwrapped(view, "autorun methods cannot have modifiers");
 	invariant(typeof view === "function", "autorun expects a function");
+	invariant(
+		isAction(view) === false,
+		"Warning: attempted to pass an action to autorun. Actions are untracked and will not trigger on state changes. Use `reaction` or wrap only your state modification code in an action."
+	);
 	if (scope)
 		view = view.bind(scope);
 
@@ -121,7 +125,10 @@ export function autorunAsync(arg1: any, arg2: any, arg3?: any, arg4?: any) {
 		delay = arg2;
 		scope = arg3;
 	}
-
+	invariant(
+		isAction(func) === false,
+		"Warning: attempted to pass an action to autorunAsync. Actions are untracked and will not trigger on state changes. Use `reaction` or wrap only your state modification code in an action."
+	);
 	if (delay === void 0)
 		delay = 1;
 
@@ -231,4 +238,4 @@ export function reaction<T>(arg1: any, arg2: any, arg3: any, arg4?: any, arg5?:
 
 	r.schedule();
 	return r.getDisposer();
-}
+}

test/autorun.js

@@ -37,3 +37,10 @@ test('autorun can be disposed on first run', function(t) {
 
 	t.end()
 });
+
+test('autorun warns when passed an action', function(t) {
+	var action = m.action(() => {});
+	t.plan(1);
+	t.throws(() => m.autorun(action), /attempted to pass an action to autorun/);
+	t.end();
+});

test/autorunAsync.js

@@ -125,3 +125,10 @@ test('autorunAsync passes Reaction as an argument to view function', function(t)
 		t.end();
 	}, 100);
 });
+
+test('autorunAsync warns when passed an action', function(t) {
+	var action = m.action(() => {});
+	t.plan(1);
+	t.throws(() => m.autorunAsync(action), /attempted to pass an action to autorunAsync/);
+	t.end();
+});