Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make isObservableArray and isObservableMap type guards. #487

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Make isObservableArray and isObservableMap type guards. #487

merged 1 commit into from
Aug 23, 2016

Conversation

Strate
Copy link
Contributor

@Strate Strate commented Aug 16, 2016

Typescript has a cool feature called user type guard functions, which helps to
narrow type of variable. This PR makes isObservableArray and isObservableMap
user type guard functions.

@Strate
Make isObservableArray and isObservableMap type guards.
008a506 
Typescript has a cool feature called `user type guard functions`, which helps to
narrow type of variable. This PR makes `isObservableArray` and `isObservableMap`
user type guard functions.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.941% when pulling 008a506 on megaplan:make_guard_functions into 56c3ad2 on mobxjs:master.

@mweststrate
Copy link
Member

cool!

@mweststrate mweststrate merged commit cb75c04 into mobxjs:master Aug 23, 2016
@mweststrate mweststrate mentioned this pull request Aug 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Strate @coveralls @mweststrate