Handle process.env correctly in build #2267
Conversation
| @@ -29,6 +29,7 @@ | |||
| "_prepublish": "yarn small-build", | |||
| "quick-build": "tsc --pretty", | |||
| "small-build": "node scripts/build.js", | |||
| "build": "node scripts/build.js", | |||
There was a problem hiding this comment.
This is the same as "small-build" I would remove one of them
There was a problem hiding this comment.
I want to standardize to build but not to remove small-build in case someone still uses that for something.
| @@ -121,6 +114,19 @@ function writePackage(versionPath, version) { | |||
| ) | |||
| } | |||
|
|
|||
| function writeIndex(versionPath) { | |||
| fs.writeFileSync( | |||
| path.resolve(versionPath, "lib", "index.js"), | |||
There was a problem hiding this comment.
This is not critical, but IMHO it's better to write this file somewhere in the codebase and just copy it as part of the build process. It will make sure that we're not making any mistake and makes the code a bit clearer.
There was a problem hiding this comment.
Yea, was thinking about it but did not want to come up with some artificial filename or folder where to keep it. It's such a small thing it's ok.
|
Can confirm that it also solves #2264 |
|
Thanks, guys. I will merge and release tomorrow, stick to X.15.2 till then, please. |
Fixes #2266 #2264
Here is the build output it creates, looks ok to me, but I could use a second pair of eyes.
v5.zip
cc @mweststrate @ranyitz @le0nik