Make initial values of observable set accept readonly array #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkcz
approved these changes
Nov 13, 2019
|
@FredyC Not quite sure about your process. Are you going to merge this PR? |
|
Well, the process generally is that someone approves and other maintainer merges. I am curious how did you even discover such an "issue"? Why does it bother you? :) |
Oh, okay, thanks for the update.
So, we try to use |
|
I can merge @FredyC |
|
Ping on this? @ItamarShDev could you merge? |
auvipy
approved these changes
Dec 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObservableSetdoesn't need to change the initial values array, so it makes sense to allow passing in areadonlyone.