Fix for #2135 #2136
Merged
Fix for #2135 #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
urugator
approved these changes
Oct 5, 2019
|
@mweststrate should this approach be used or the globlal state versioning one? |
|
I think this is ok |
mweststrate
approved these changes
Oct 12, 2019
|
@mweststrate can we please have a patch release of this? |
|
Released 4/5.14.1
…On Tue, Oct 15, 2019 at 7:19 AM thecodejack ***@***.***> wrote:
@mweststrate <https://github.com/mweststrate> can we please have a patch
release of this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2136?email_source=notifications&email_token=AAN4NBFL7V6XMATKJJMWQ5LQOVOI3A5CNFSM4I5LTZCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBHR6LY#issuecomment-542056239>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN4NBE5MK6RAZCNXY6WS73QOVOI3ANCNFSM4I5LTZCA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using the global state for the action stack checks (which might be uninitialized in older mobx versions) it will just rely on local state.
In theory this means the check will be less effective (since it will only check the stack of actions called using the same mobx version are ok), but less likely to break in multiple mobx version scenarios.
Should fix #2135